PVS-Studio Analysis Results


Date:Thu May 18 15:08:19 2023
PVS-Studio Version:7.23.69221.300
Command Line:plog-converter -a GA\:1,2,3 -t fullhtml --indicate-warnings build/f7-firmware-DC/pvsreport.log -o build/f7-firmware-DC/pvsreport
Total Warnings (GA):23
Group Location Level Code Message
General Analysis nfc_scene_mf_ultralight_unlock_warn.c:23 Medium V557 Array overrun is possible. The value of 'i' index could reach 7.
General Analysis nfc_rpc.c:43 Low V576 Incorrect format. Consider checking the fourth actual argument of the 'furi_log_print_format' function. The integer argument of 32-bit size is expected.
General Analysis nfc_rpc.c:113 Low V576 Incorrect format. Consider checking the fourth actual argument of the 'furi_log_print_format' function. The integer argument of 32-bit size is expected.
General Analysis nfc_rpc_mf_ultralight.c:145 High V512 A call of the 'memcpy' function will lead to overflow of the buffer 'pb_mf_ul_read_counter_resp.data.bytes'.
General Analysis nfc_rpc_mf_ultralight.c:145 High V512 A call of the 'memcpy' function will lead to the 'data.data' buffer becoming out of range.
General Analysis nfc_rpc_mf_ultralight.c:178 Low V576 Incorrect format. Consider checking the fourth actual argument of the 'furi_log_print_format' function. The SIGNED argument of memsize type is expected.
General Analysis f_hal_nfc_event.c:39 Low V605 Consider verifying the expression: event_flag != FuriFlagErrorTimeout. An unsigned value is compared to the number -2.
General Analysis f_hal_nfc.c:88 Medium V519 The 'error' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 77, 88.
General Analysis f_hal_nfc_timer.c:54 High V1051 Consider checking for misprints. It's possible that the 'timer' should be used inside 'LL_TIM_IsActiveFlag_UPDATE' function.
General Analysis nfc_data_generator.c:146 Medium V1086 A call of the 'memcpy' function will lead to underflow of the buffer 'default_data_ntag203'.
General Analysis nfc.c:104 High V579 The f_hal_nfc_poller_rx function receives the pointer and its size as arguments. It is possibly a mistake. Inspect the second argument.
General Analysis nfc_dev.c:172 Medium V619 The array 'mfu_data->tearing_flag' is being utilized as a pointer to single object.
General Analysis nfc_dev.c:426 Low V1027 Pointer to an object of the 'MfClassicBlock' class is cast to unrelated 'MfClassicSectorTrailer' class.
General Analysis nfc_device.c:815 High V547 Expression '(block_unknown_bytes_mask & 0x003f) == 0' is always false.
General Analysis nfc_device.c:821 High V547 Expression '(block_unknown_bytes_mask & 0x03c0) == 0' is always false.
General Analysis nfc_device.c:826 High V547 Expression '(block_unknown_bytes_mask & 0xfc00) == 0' is always false.
General Analysis nfc_device.c:831 High V547 Expression 'block_unknown_bytes_mask == 0' is always false.
General Analysis mf_classic.c:88 Low V1027 Pointer to an object of the 'MfClassicBlock' class is cast to unrelated 'MfClassicSectorTrailer' class.
General Analysis mf_ultralight_listener.c:183 Medium V1086 A call of the 'memcpy' function will lead to underflow of the buffer 'instance->tx_data'.
General Analysis mf_ultralight_listener.c:269 Medium V619 The array 'instance->data->tearing_flag' is being utilized as a pointer to single object.
General Analysis mf_ultralight_listener.c:290 High V512 A call of the 'memcpy' function will lead to overflow of the buffer 'password.data'.
General Analysis mf_ultralight.c:205 Low V1027 Pointer to an object of the 'MfUltralightPage' class is cast to unrelated 'MfUltralightConfigPages' class.
General Analysis nfca_listener.c:112 Medium V547 Expression 'instance->callback' is always true.